Just wanted to share this here and solicit some feedback:

https://github.com/fabpot/symfony/pull/575

Without repeating the pull request comments word-for-word, here are two
points:

   1. The factory-method property currently used either factory-service or
   class (in the absence of factory-service).  Class is also used for inferring
   the class of the service itself, so this was ambiguous for factories that
   don't also return instances of themselves.  Having an explicit factory-class
   property removes the ambiguity and also makes the validation simpler.
   2. While implementing this, I noticed that interface injection is ignored
   for factory-generated services.  Johannes commented that there's no problem
   appending method calls to factory-generated service definition, so we can
   probably remove this limitation.  I would suggest doing that in a separate
   pull request / enhancement.


-- 
jeremy mikola

-- 
If you want to report a vulnerability issue on symfony, please send it to 
security at symfony-project.com

You received this message because you are subscribed to the Google
Groups "symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en

Reply via email to