Yes, stof also noticed the name didn't follow conventions. Per the DI extension, I think the general rule should be to show the use of imports. The extension is just a touch more advanced.
@weaverryan On Feb 21, 2011 6:27 AM, "Lukas Kahwe Smith" <[email protected]> wrote: > > On 18.02.2011, at 23:12, kamilente wrote: > >> Hello everyone, >> >> it's really a minor thing, but can be confusing for unexperienced >> users. >> >> It seems that the HelloBundle in the Sandbox is ignoring naming >> conventions defined in http://docs.symfony-reloaded.org/master/guides/bundles/best_practices.html >> - it's Sensio\HelloBundle\HelloBundle instead of Sensio\HelloBundle >> \SensioHelloBundle. >> >> Is there a reason for this? >> >> As an unexperienced user I found it confusing: did I misunderstand the >> (clear) best practices, or are they effectively disregarded in the >> first example of a Bundle most users will see? > > > Could you send a pull to fix this? > > BTW: Should we either add a DI extension to the HelloBundle or add in another Bundle that also has a DI extension? > > regards, > Lukas Kahwe Smith > [email protected] > > > > -- > If you want to report a vulnerability issue on symfony, please send it to security at symfony-project.com > > You received this message because you are subscribed to the Google > Groups "symfony developers" group. > To post to this group, send email to [email protected] > To unsubscribe from this group, send email to > [email protected] > For more options, visit this group at > http://groups.google.com/group/symfony-devs?hl=en -- If you want to report a vulnerability issue on symfony, please send it to security at symfony-project.com You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en
