2011/2/25 Matt Robinson <[email protected]>:
> 1. I think we'd all rather it was right than on time, but at the risk of 
> invoking the Mythical Man-Month, could you get more help? :)

Yes, particularly in two areas: Test coverage of the new classes needs
to be improved, and existing functionality has to be thouroughly
tested manually.

> 2. There's something about the way you bind that feels a bit off to me. You 
> pass $post into the factory, which is fine, but then the next time you see 
> $post is when you're persisting it. It kind of feels like it's been modified 
> mysteriously.

As Jon said, it's normal pass by reference. Form::bind() handles the
translation of object to form values and back.

2011/2/25 Tim Nagel <[email protected]>:
> I will attempt to put aside some of my time this weekend to go over it and
> see if I cant assist to help stuff get done.

Great. Could you send me your IM data?

2011/2/25 Benjamin Eberlei <[email protected]>:
> 1. Is this optional?

No, otherwise it wouldn't be a BC break.

> 2. Has the public API changed alot? Can i still use it with new?

No you can't. There are no separate field classes anymore, you now
need to call the getters on FormFactory. You can of course create a
field manually and do all the configuration yourself, but then you're
on your own.

> 3. Is passing the renderer to the view mandatory, or can the view helpers
> get around this using a form instance?

You can also pass the form itself and access the renderer in the template.

{{ form.renderer.widget }}

2011/2/25 John Wards <[email protected]>:
> Where are the major BC breaks? From my quick look you can still define
> a class like this:
>
> https://gist.github.com/843530

No you can't. There is no "TextField" class anymore, you need to call
getTextField() on FormFactory now. So you _could_ create a form class
and inject all dependencies manually, but that's more work.

Bernhard

-- 
If you want to report a vulnerability issue on symfony, please send it to 
security at symfony-project.com

You received this message because you are subscribed to the Google
Groups "symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en

Reply via email to