On 27.02.2011, at 19:35, Lukas Kahwe Smith wrote: > Hi, > > I have run the Symfony2 source through the phpStorm code analyzer once again. > Here are the results after inspecting things by hand. It should be noted that > due to all the false positives I skipped looking at undefined variables and > methods. Guess each of the cases should be reviewed and pulls be made. > > Here are the changes that looked sensible while I was going through things: > https://github.com/symfony/symfony/pull/120 > > There are the issues where I didnt quickly see the solution:
Doctrine\Common\Cli related stuff is already fixed in: https://github.com/pborreli/symfony/commit/1e7a2e13cd53e4f83e948e63035f88992e8d27cb Leaving just > diff --git a/src/Symfony/Bundle/DoctrineBundle/DoctrineBundle.php > b/src/Symfony/Bundle/DoctrineBundle/DoctrineBundle.php > index 38e61b1..8dd0d1c 100644 > --- a/src/Symfony/Bundle/DoctrineBundle/DoctrineBundle.php > +++ b/src/Symfony/Bundle/DoctrineBundle/DoctrineBundle.php > @@ -11,6 +11,7 @@ > > namespace Symfony\Bundle\DoctrineBundle; > > +// TODO broken? > use > Symfony\Bundle\DoctrineBundle\DependencyInjection\Compiler\CreateProxyDirectoryPass; > use Symfony\Component\DependencyInjection\Compiler\PassConfig; > use > Symfony\Bundle\DoctrineBundle\DependencyInjection\Compiler\RegisterEventListenersAndSubscribersPass; > diff --git > a/src/Symfony/Bundle/DoctrineMongoDBBundle/Command/LoadDataFixturesDoctrineODMCommand.php > > b/src/Symfony/Bundle/DoctrineMongoDBBundle/Command/LoadDataFixturesDoctrineODMCommand.php > index bcaf9e0..05693e6 100644 > --- > a/src/Symfony/Bundle/DoctrineMongoDBBundle/Command/LoadDataFixturesDoctrineODMCommand.php > +++ > b/src/Symfony/Bundle/DoctrineMongoDBBundle/Command/LoadDataFixturesDoctrineODMCommand.php > @@ -19,6 +19,7 @@ use Symfony\Component\Console\Output\Output; > use Symfony\Component\Finder\Finder; > use Symfony\Bundle\FrameworkBundle\Util\Filesystem; > use Symfony\Bundle\DoctrineAbstractBundle\Common\DataFixtures\Loader as > DataFixturesLoader; > +// TODO broken? > use Doctrine\Common\Cli\Configuration; > use Doctrine\Common\Cli\CliController as DoctrineCliController; > use Doctrine\Common\DataFixtures\Executor\MongoDBExecutor; > @@ -89,4 +90,4 @@ EOT > }); > $executor->execute($fixtures, $input->getOption('append')); > } > -} > \ No newline at end of file > +} > diff --git a/src/Symfony/Bundle/TwigBundle/Extension/TemplatingExtension.php > b/src/Symfony/Bundle/TwigBundle/Extension/TemplatingExtension.php > index d7ecb93..b4b3140 100644 > --- a/src/Symfony/Bundle/TwigBundle/Extension/TemplatingExtension.php > +++ b/src/Symfony/Bundle/TwigBundle/Extension/TemplatingExtension.php > @@ -13,6 +13,7 @@ namespace Symfony\Bundle\TwigBundle\Extension; > > use Symfony\Component\DependencyInjection\ContainerInterface; > use Symfony\Bundle\TwigBundle\TokenParser\IncludeTokenParser; > +// TODO broken? > use Symfony\Bundle\TwigBundle\TokenParser\UrlTokenParser; > use Symfony\Bundle\TwigBundle\TokenParser\PathTokenParser; > use Symfony\Bundle\TwigBundle\TokenParser\RenderTokenParser; > diff --git a/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php > b/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php > index 1442f4f..7528e99 100644 > --- a/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php > +++ b/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php > @@ -235,6 +235,7 @@ EOF; > if ($processed->contains($sDefinition)) { > continue; > } > + /// TODO: broken? > $processed->offsetSet($sDefinition); > > $class = $this->dumpValue($sDefinition->getClass()); > @@ -428,6 +429,7 @@ EOF; > if ($processed->contains($iDefinition)) { > continue; > } > + // TODO broken? > $processed->offsetSet($iDefinition); > > if (!$this->hasReference($id, $iDefinition->getMethodCalls())) { regards, Lukas Kahwe Smith [email protected] -- If you want to report a vulnerability issue on symfony, please send it to security at symfony-project.com You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en
