On 08.03.2011, at 17:41, Lukas Kahwe Smith wrote:

> Hi Thomas,
> 
> First up thanks for the AdminBundle [1]
> I want to start working on making the Bundle work for ODM's.
> 
> While reviewing the code I noticed that there is a lot of code in the 
> Controllers that we could maybe move to helpers. This is imho especially 
> important as right now there is a lot of "format" specific code, that people 
> might want to handle differently. For example I would like to use the 
> ViewBundle [2]. Others might want to intentionally not support json or might 
> prefer to use twig templates for json etc.
> 
> So I think in general its a good idea to make the Controllers as slim as 
> possible, by moving as form logic to the form classes, maybe adding a few 
> helper services etc. Do you agree? This way its easier to get an overview 
> when inheriting or its more realistic to re-implement Controllers from 
> scratch.


i should add that those helpers should make it easier to support ODM specific 
features. for example in the PHPCR ODM [3] we have a dedicated API for managing 
tree structures. so i would want to use a different helper when using PHPCR ODM

regards,
Lukas Kahwe Smith
[email protected]

[3] https://github.com/doctrine/phpcr-odm

-- 
If you want to report a vulnerability issue on symfony, please send it to 
security at symfony-project.com

You received this message because you are subscribed to the Google
Groups "symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en

Reply via email to