On 3/14/11 9:33 PM, Jakub Zalas wrote:
On Mar 11, 3:21 pm, ryan weaver<[email protected]> wrote:
Hey Jakub!
I somehow didn't actually meet you in Paris - a shame, let's fix that next
year!
Definitely. Symfony Day might work as well ;)
1. Each test or group of tests that represent one tested "feature" should
probably be committed on their own branch and sent as their own pull request
to core. So, if 10 developers all write tests for 2 "features" each, then
each developer would have created 2 new branches on their fork and Fabien
would have 20 beautiful pull requests to merge in.
As a contrary it might be hell of a job to verify and accept one big
pull request. Still, I agree with you it's better.
Smaller pull requests are always better.
As longs as there are only tests it's fine. I think we could create
separate pull requests in case of bugs/code changes.
3. Depends. If you can fix the bug, then I'd put it in the same pull
request. If you can't, but your sure that the test is really revealing a
bug, I still think that should be sent as a pull request. In that PR, you
could say that this test exposes a bug, but fixing it was beyond some
developer's scope (I've done this before for the ODM).
Yes, I completely agree..
4. In theory, yes! If others want to organize local test fests, then you can
all organize together. But even if nobody else speaks up now, a successful
test fest in Poland will set a great tone and others will follow your lead.
We talked a little about this at the conference - if you can organize
something small quickly, it's better than organizing something *huge* that
might take months to really get moving.
Agree. I think I will even start with a small group of friends and
later advertise it a bit more.
On Mar 14, 8:06 pm, Jeremy Mikola<[email protected]> wrote:
Jakub,
This is a great idea, and in line with the first unconference discussion
(Stefan's community-building topic) a few of us had at Symfony Live.
Unfortunately I missed it.
If you're all collaborating in person, the easiest way to coordinate on
Github might be to make a public organization with a fork of Symfony2, and
you can all collaborate there. If everyone had access to the organization's
fork repository, it should preserve all of the authorship and make it easier
to combine efforts (vs using personal forks and having to add each other as
remote repositories). You could even submit pull requests from the
organization's fork. After everything is accepted, you could wipe the
organization account to keep from littering Github :)
That's an excellent idea. I'm digging into Github organizations at the
moment. Thanks!
I think you don't need that. Everyone should fork the main repo and make
pull requests.
Fabien
--
Jakub Zalas
--
If you want to report a vulnerability issue on symfony, please send it to
security at symfony-project.com
You received this message because you are subscribed to the Google
Groups "symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en
