We could add a method ->getMessageKey() to the AuthenticationException. Kind regards, Johannes
On Thu, Mar 17, 2011 at 6:09 PM, Lukas Kahwe Smith <[email protected]>wrote: > > On 22.02.2011, at 21:39, Fabien Potencier wrote: > > > On 2/22/11 11:15 AM, Jordi Boggiano wrote: > >> Sooo.. it seems more or less everyone is on the message keys side. > >> > >> Fabien can you concede this one or is it really an issue for you? > > > > My only concern, and one that Bernhard mentionned, is that it adds the > Translation component as a mandatory dependency to Validator. Moreover, it > means that even if you website is not i18n, you must use the Translation > component and the Twig extension in your templates. > > > > So, I would recommend to keep the validator messages as is and use keys > for end-use applications. > > > What about Exceptions form the Security layer? > > BTW right now there is a security issue there anyway, since its impossible > to determine what is ok to display: > http://trac.symfony-project.org/ticket/9523 > > But the next effect is that the Security layer will trigger an Exception on > a login failure and the user will have to display some message. > > regards, > Lukas Kahwe Smith > [email protected] > > > > -- > If you want to report a vulnerability issue on symfony, please send it to > security at symfony-project.com > > You received this message because you are subscribed to the Google > Groups "symfony developers" group. > To post to this group, send email to [email protected] > To unsubscribe from this group, send email to > [email protected] > For more options, visit this group at > http://groups.google.com/group/symfony-devs?hl=en > -- If you want to report a vulnerability issue on symfony, please send it to security at symfony-project.com You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en
