On 14.04.2011, at 13:25, Johannes wrote:

> Just want to add some more options here which I mentioned on the
> respective pull requests already:
> 
> 5) Disabling interface injection on a per-method basis:
>    foo:
>        disable_interface_injection:
>            setContainer: true
> 
> 6) Prepending calls from interface injection instead of appending them
> 
> 7) Making it easier to disable interface injection globally
>    $passConfig->disableInterfaceInjectionPass()
> 
> IMO 6) is easiest to implement, and is consistent with what we already
> do for definition inheritance.


6) kinda fails for the same reason of why 
https://github.com/symfony/symfony/pull/541 was reverted, it will fail if 
repeated calls to the same method are not overwriting previous calls.

I like 5) better than what I wrote for 4)

7) is a bit harsh and will also make bundles break that rely on interface 
injection without giving the user a way to customize the service definition.

regards,
Lukas Kahwe Smith
[email protected]



-- 
If you want to report a vulnerability issue on symfony, please send it to 
security at symfony-project.com

You received this message because you are subscribed to the Google
Groups "symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en

Reply via email to