On 4/20/11 4:55 PM, Michel wrote:
Hi everyone,

I would like to have some updates concerning this issue. If it is
currently in development or not.

I've just committed this feature:

https://github.com/symfony/symfony/commit/7266b41aded2db6a88f980431752f25688cb204b

Fabien

If not I could do it myself in the comming days and push it to the
git. Thus, do you have any recommandation on how to inject the _locale
value to the url generator ? Right now I see two possibilities :
1. injecting the session to the UrlGenerator, which is very ugly
2. expose a parameterbag from the url generator, which contains
aditionnal default values that can be set pragmatically, and fill it
when the _locale value is filled

Do you see any more option ?

Michel

On 14 avr, 15:59, Fabien Potencier<fabien.potenc...@symfony-
project.com>  wrote:
On 4/14/11 3:17 PM, ryan weaver wrote:

Hey guys-

I'm bringing this back up again - after seeing a user ask about it in
#symfony.

When generating routes, I think the_localeparameter should be
automatically set from the locale set on the user's session (with the
normal fallback mechanism). The_localerouting parameter value is
automatically set to the users session, but opposite direction (using
the session's locale to populate the_localeparameter when generating
routes) is not true.

Last time I looked, implementing this was not immediately obvious - but
I wanted to at least see if others agree that this should be the desired
behavior.

I had a discussion about this same topic this morning. We are going to
"fix" this in the coming days.

Fabien







Thanks!

Ryan Weaver
US Office Head&  Trainer - KnpLabs - Nashville, TN
http://www.knplabs.com<http://www.knplabs.com/en>
http://www.thatsquality.com
Twitter: @weaverryan

On Sun, Jan 2, 2011 at 1:39 PM, weaverryan<[email protected]
<mailto:[email protected]>>  wrote:

     Hey guys-

     Currently, when the route parameter "_locale" is matched, that value
     is set as the session's locale. However, when generating URLs, the
     session's locale is not automatically used as the_localerouting
     default if none is specified.

     Has this feature been purposefully omitted or are we just waiting for
     someone to implement it? More generally, with how the route generator
     compiles, the solution seems non-trivial.

     Thoughts?

     --
     If you want to report a vulnerability issue on symfony, please send
     it to security at symfony-project.com<http://symfony-project.com>

     You received this message because you are subscribed to the Google
     Groups "symfony developers" group.
     To post to this group, send email to [email protected]
     <mailto:[email protected]>
     To unsubscribe from this group, send email to
     [email protected]
     <mailto:symfony-devs%[email protected]>
     For more options, visit this group at
    http://groups.google.com/group/symfony-devs?hl=en

--
If you want to report a vulnerability issue on symfony, please send it
to security at symfony-project.com

You received this message because you are subscribed to the Google
Groups "symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en


--
If you want to report a vulnerability issue on symfony, please send it to 
security at symfony-project.com

You received this message because you are subscribed to the Google
Groups "symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en

Reply via email to