On 4/19/11 11:11 PM, Jeremy Mikola wrote:
Was there any problem before PR535 <%20https://github.com/symfony/symfony/pull/535> was introduced and container injection for ContainerAwareInterface was added to core? If not, perhaps that can simply be removed.
The introduction of the ContainerAwareInterface in the DIC proved the fragility of the feature. If you decide to add an interface in your configuration, you can potentially break someone else code (in a third-party bundle for instance). And of course, you cannot fix it.
That's why I think the removal of the feature is the only viable solution. Fabien
Johannes: if interface injection is removed entirely, is it something that can be off-loaded to a bundle? I know a lot of its meat is in the compiler pass, which can be injected via a bundle, but I'm curious about the internals for the DI component. On Tue, Apr 19, 2011 at 5:04 PM, Lukas Kahwe Smith <[email protected] <mailto:[email protected]>> wrote: On 19.04.2011, at 22:51, Fabien Potencier <[email protected] <mailto:[email protected]>> wrote: > After a short discussion with Bulat, I propose to remove interface > injection from the DIC altogether. The added benefit is quite small and > it's not easy to make it for edge cases like the one exposed by Lukas. > So, instead of adding even more complexity to a very small feature, > let's remove it altogether. this is certainly a solution with which i can live. regards Lukas -- If you want to report a vulnerability issue on symfony, please send it to security at symfony-project.com <http://symfony-project.com> You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] <mailto:[email protected]> To unsubscribe from this group, send email to [email protected] <mailto:symfony-devs%[email protected]> For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en -- jeremy mikola -- If you want to report a vulnerability issue on symfony, please send it to security at symfony-project.com You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en
-- If you want to report a vulnerability issue on symfony, please send it to security at symfony-project.com You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en
