After reading your mail, I don't really understand why, and more importantly why now? Such a change would break almost everything out there.
Maybe you can elaborate the pros and cons of this a bit more? This probably also has a performance impact? Kind regards, Johannes On Tue, Apr 26, 2011 at 8:12 AM, Hugo Hamon <[email protected]> wrote: > Hi Fabien, > > I'm for adding proxy method to access public attributes in Request and > Response. Especially for the Response with a setCookie() method. > > Hugo Hamon. > Sensio Labs Trainings Manager. > > Le 26/04/11 08:09, « Fabien Potencier » > <[email protected]> a écrit : > > >Hi all, > > > >I know that some of you are not comfortable with the public properties > >we have in Request and Response. These are the only examples of public > >properties in the framework: > > > >Request: > > > >$attributes > >$request > >$query > >$server > >$cookies > >$headers > > > >Response: > > > >$headers > > > >Instead of public properties, we can convert them into proper getters: > > > >getAttributes(), getQuery(), getHeaders(), ... > > > >If we do that, we should probably add proxy methods for common usage: > > > >$request->getQueryParam(), $request->getRequestParam(), ... > >$response->setCookie(), $response->setHeader() > > > >What do you think? > > > >Fabien > > > >-- > >Fabien Potencier > >Sensio CEO - Symfony lead developer > >sensiolabs.com | symfony.com | fabien.potencier.org > >Tél: +33 1 40 99 80 80 > > > >-- > >If you want to report a vulnerability issue on symfony, please send it to > >security at symfony-project.com > > > >You received this message because you are subscribed to the Google > >Groups "symfony developers" group. > >To post to this group, send email to [email protected] > >To unsubscribe from this group, send email to > >[email protected] > >For more options, visit this group at > >http://groups.google.com/group/symfony-devs?hl=en > > > > > > > > > -- > If you want to report a vulnerability issue on symfony, please send it to > security at symfony-project.com > > You received this message because you are subscribed to the Google > Groups "symfony developers" group. > To post to this group, send email to [email protected] > To unsubscribe from this group, send email to > [email protected] > For more options, visit this group at > http://groups.google.com/group/symfony-devs?hl=en > -- If you want to report a vulnerability issue on symfony, please send it to security at symfony-project.com You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en
