I created a new PR: https://github.com/symfony/symfony/pull/2903
On Dec 16, 1:45 am, Fabien Potencier <fabien.potenc...@symfony-
project.com> wrote:
> On 12/15/11 7:06 PM, Kevin Bond wrote:
>
> > Hey Guys,
>
> > I want to get the ball rolling on creating a PR for this but had a few
> > questions/concerns before I start.
>
> > 1) How could we display default content? I think we would need
> > another tag (ie {% hinclude ... %}default{% endhinclude %}) where we
> > could set content (similar to the block tag) - unless we change the {%
> > render %} tag to have an {% endrender %}. It was my understanding
> > from the irc meeting that if we couldn't integrate it into the {%
> > render %} tag then it wouldn't be in core.
>
> Adding support for an optional endrender tag is easy to implement (I can
> do it myself if you don't know Twig's internals).
>
> > 2) I do like the idea of using hinclude, and am all for setting/
> > keeping a standard, but there should still be a way to override it if
> > needed correct?
>
> No, if someone want to use something else, then he has to implement it
> himself (the same already goes for ESI support).
>
> > 3) I actually have a concern with hinclude itself: there doesn't seem
> > to be a way to specify the "include_mode" at the tag level, only
> > globally.
>
> > Yesterday I was dead set that a js content feature should be in core
> > but am now starting to share lsmith's hesitation. Maybe a 3rd party
> > hinclude bundle (which I don't mind starting) is a better solution.
>
> Let's see how the implementation looks like to determine if it belongs
> to the core or not. For instance, 1) can still be added to the core even
> if the hinclude feature itself is implemented in a bundle.
>
> Fabien
>
>
>
>
>
>
>
> > Thoughts? Comments?
--
If you want to report a vulnerability issue on symfony, please send it to
security at symfony-project.com
You received this message because you are subscribed to the Google
Groups "symfony developers" group.
To post to this group, send email to symfony-devs@googlegroups.com
To unsubscribe from this group, send email to
symfony-devs+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en
