Hi, If I read yesterday's logs right then the main issue with https://github.com/symfony/symfony/pull/2853 is the changes to the flash system.
Now first up if there is already agreement on the rest of the PR, then it might be worthwhile to unbundle the flash changes as much as possible from this PR to get at least the session changes in there. However that then raises the question if only the message stack changes should be removed or if also the option to clear on read should be removed. Now to address the area where there is disagreement. What Drak has done and what many are asking for is to expand the flash message system to become a generic notification system and to see flash messages just as one use case of such a notification system. One thing which I understand we all agreed on is that such messages should be possible to be displayed inside a layout template. So the messages themselves need to contain all information necessary to display them. Meaning the CSS class to use should be possible to be deduced from the message key for example. Furthermore it cannot be unclear of the message still needs to be translated or not etc. Some use cases: 1) show the results of a simple form submission (common flash message use case) 2) show the results of bulk upload form (requires a stack, but the logic can be centralized to manage the stack on top of the current flash system .. aka the stack is the message) 3) allow listeners to notify about issues (f.e. in magento they have notifications if the product index needs updating) Use case 1) is supported with the current approach, use case 2) needs some additional code, but can also be managed by the current approach. 3) requires a notification system where messages are stacked by type. Now we have a few options: A) ignore use case 3) (aka what Symfony 2.0 does) B) introduce a separate solution for notifications C) expand the flash message system (aka what drak's PR does) I personally think that C) is the right way to go. Anyone using drak's approach will simply need to adapt their layout to handle getting back an array with a single value instead of just a scalar. regards, Lukas Kahwe Smith m...@pooteeweet.org -- If you want to report a vulnerability issue on symfony, please send it to security at symfony-project.com You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to symfony-devs@googlegroups.com To unsubscribe from this group, send email to symfony-devs+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en
