Hello, After a chat with vicb I've decided to open this thread. Basically I see two major flaws in the current way Symfony2 community is organized and I believe if these would be covered the we could drive the framework to something even better. Since both of the issues are on the same grade of the relevance I'll just list them in a random order: a) the lack of documentation when a BIG change is done; b) the time it sometime takes for a PR to be either merged or rejected.
a) This should be some sort of a mandatory thing when doing a PR for Symfony that has been approved. Adding at least a minimum amount of documentation about what does the PR does or changes in the system would be welcomed both by the team maintaining the documentation and the users who would pick-up the changes and use them. I'm thinking here about even the smallest PR that for example the one with StreamedResponse. That was a good PR because the documentation about it also appears. But the PR about adding a JsonResponse isn't good because it doesn't contain any PR for the documentation. (I've picked them up randomly) b) The amount of time it sometimes takes to merge a PR it's huge. I'm sorry to say it but there are PRs there that have 5-6 months, like this one https://github.com/symfony/symfony/pull/2570 , and the original author might don't be have time to rebase the code and so on. I think there should be a reasonable amount of time before commit / don't commit / more work needed statuses, one or two weeks could be a good start, but at the end of that period the commit should either be merged or declined. If the commit receives comments that it need changes then that period should be counted since last update on it, be it comment requiring some sort of improvement or commit done for it. I know that people might not have time to work on Symfony2 PRs every week but I also believe that having a reasonable amount of time before a PR is either merged or declined would improve the rate at which PRs are closed and would help contributors pick up more relevant issues that need to be fixed or that they feel like worth adding. Plus it would make them more easily maintainable while they are in the PR state. I might not have the best possible English and somethings might not be clear from the beginning what I've wrote so please ask me if something doesn't sound right in what I've wrote above. Kind regards and thank you all for making Symfony2 one of the best frameworks out there! -- If you want to report a vulnerability issue on symfony, please send it to security at symfony-project.com You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to symfony-devs@googlegroups.com To unsubscribe from this group, send email to symfony-devs+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en
