That is very good news! I'll see what I can do about the Doctrine test part.
Maybe when I'm done we could then open a ticket with both patches attached? That would improve the chances of the patch being accepted soon and DbFinder updated for symfony 1.4. One potential problem is that the admin generator feature relies on symfony 1.0 code and therefore would have to be completely rewritten or entirely removed for the time being. But that is for Francois to decide. :) Cheers, Daniel On 2009-12-06, at 6/December, 3:26 PM, Jan Fabry wrote: > On Dec 3, 11:50 am, Daniel Lohse <[email protected]> wrote: >> Alright, there you go, it's really only 2 lines changed at this time. :) >> >> Report back if you're hitting any roadblocks but my app uses hydration/joins >> quite extensively and it works just like before (minus that little bug I >> mentioned which I have to hunt down today, will report back if it's >> something to do with DbFinder). > > I have updated the unit tests for the Propel part, and they all pass > with this patch. I did need to rewrite some tests (to adapt them to > syntax changes in the output of Propel 1.4, or to make them completely > isolated from other tests), but I will wrap up those changes in > another post to this list or in a Trac ticket. > > I did not yet go through the Doctrine or common tests, since that will > probably require more work in the DbFinder code - maybe someone with > more knowledge of the Doctrine internals could start with that? > > Greetings, > > Jan Fabry > > -- > > You received this message because you are subscribed to the Google Groups > "symfony users" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/symfony-users?hl=en. > > -- You received this message because you are subscribed to the Google Groups "symfony users" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/symfony-users?hl=en.
