Comment #7 on issue 1267 by ondrej.certik: improve our str printer:
1/cos(x)*sin(x) -> sin(x)/cos(x)
http://code.google.com/p/sympy/issues/detail?id=1267
The patch is ok, all tests pass. But unfortunately the following doctest
fail. Do you
think you could please fix it as well? I am attaching the patch with the
fixed
whitespace.
Thanks a lot.
$ bin/doctest
============================= test process starts
==============================
executable: /usr/bin/python (2.6.1-final-0)
[...]
sympy/concrete/products.py[0]
[OK]
sympy/concrete/summations.py[2] F.
[FAIL]
sympy/concrete/sums_products.py[0]
[OK]
sympy/functions/combinatorial/factorials.py[4] ....
[OK]
sympy/functions/combinatorial/numbers.py[5] ...F.
[FAIL]
sympy/functions/elementary/__init__.py[0]
[OK]
sympy/functions/elementary/complexes.py[4] ....
[OK]
sympy/functions/special/__init__.py[0]
[OK]
sympy/functions/special/delta_functions.py[2] .F
[FAIL]
sympy/functions/special/error_functions.py[0]
[OK]
sympy/functions/special/gamma_functions.py[0]
[OK]
sympy/functions/special/polynomials.py[7] ..F.F..
[FAIL]
sympy/functions/special/spherical_harmonics.py[0]
[OK]
sympy/geometry/curve.py[1] .
[OK]
sympy/geometry/ellipse.py[2] F.
[FAIL]
sympy/geometry/polygon.py[5] .....
[OK]
sympy/geometry/util.py[2] .F
[FAIL]
sympy/integrals/__init__.py[0]
[OK]
sympy/integrals/risch.py[2] ..
[OK]
sympy/integrals/trigonometry.py[1] F
[FAIL]
sympy/interactive/__init__.py[0]
[OK]
sympy/polys/integerpolys.py[1] .
[OK]
sympy/polys/monomial.py[1] .
[OK]
sympy/polys/polynomial.py[17] ..............F..
[FAIL]
sympy/polys/rootfinding.py[4] ....
[OK]
sympy/series/gruntz.py[0]
[OK]
sympy/series/limits.py[2] F.
[FAIL]
sympy/series/order.py[1] .
[OK]
sympy/simplify/rewrite.py[1] .
[OK]
sympy/simplify/simplify.py[9] ..F.F....
[FAIL]
sympy/simplify/sqrtdenest.py[0]
[OK]
sympy/solvers/__init__.py[0]
[OK]
sympy/solvers/recurr.py[3] ...
[OK]
sympy/solvers/solvers.py[7] ......F
[FAIL]
sympy/statistics/__init__.py[0]
[OK]
sympy/statistics/distributions.py[5] F.FF.
[FAIL]
sympy/thirdparty/__init__.py[0]
[OK]
sympy/utilities/source.py[0]
[OK]
________________________________________________________________________________
________________ sympy.concrete.summations.Sum.euler_maclaurin
_________________
File "/home/ondrej/repos/sympy/sympy/concrete/summations.py", line 111, in
sympy.concrete.summations.Sum.euler_maclaurin
Failed example:
Sum(k, (k, 2, b)).euler_maclaurin()
Expected:
(-1 + b/2 + 1/2*b**2, 0)
Got:
(-1 + b/2 + b**2/2, 0)
**********************************************************************
File "/home/ondrej/repos/sympy/sympy/concrete/summations.py", line 113, in
sympy.concrete.summations.Sum.euler_maclaurin
Failed example:
Sum(k, (k, 2, b)).doit()
Expected:
-1 + b/2 + 1/2*b**2
Got:
-1 + b/2 + b**2/2
________________________________________________________________________________
________________ sympy.functions.combinatorial.numbers.harmonic
________________
File "/home/ondrej/repos/sympy/sympy/functions/combinatorial/numbers.py",
line 404,
in sympy.functions.combinatorial.numbers.harmonic
Failed example:
harmonic(oo, 2)
Expected:
1/6*pi**2
Got:
pi**2/6
________________________________________________________________________________
_________ sympy.functions.special.delta_functions.DiracDelta.simplify
__________
File "/home/ondrej/repos/sympy/sympy/functions/special/delta_functions.py",
line 79,
in sympy.functions.special.delta_functions.DiracDelta.simplify
Failed example:
DiracDelta(x*y).simplify(x)
Expected:
1/abs(y)*DiracDelta(x)
Got:
DiracDelta(x)/abs(y)
**********************************************************************
File "/home/ondrej/repos/sympy/sympy/functions/special/delta_functions.py",
line 81,
in sympy.functions.special.delta_functions.DiracDelta.simplify
Failed example:
DiracDelta(x*y).simplify(y)
Expected:
1/abs(x)*DiracDelta(y)
Got:
DiracDelta(y)/abs(x)
**********************************************************************
File "/home/ondrej/repos/sympy/sympy/functions/special/delta_functions.py",
line 84,
in sympy.functions.special.delta_functions.DiracDelta.simplify
Failed example:
DiracDelta(x**2+x-2).simplify(x)
Expected:
1/3*DiracDelta(-1 + x) + 1/3*DiracDelta(2 + x)
Got:
DiracDelta(-1 + x)/3 + DiracDelta(2 + x)/3
________________________________________________________________________________
_____________ sympy.functions.special.polynomials.chebyshevt_root
______________
File "/home/ondrej/repos/sympy/sympy/functions/special/polynomials.py",
line 135, in
sympy.functions.special.polynomials.chebyshevt_root
Failed example:
chebyshevt_root(3, 2)
Expected:
-1/2*3**(1/2)
Got:
-3**(1/2)/2
________________________________________________________________________________
_____________ sympy.functions.special.polynomials.chebyshevu_root
______________
File "/home/ondrej/repos/sympy/sympy/functions/special/polynomials.py",
line 162, in
sympy.functions.special.polynomials.chebyshevu_root
Failed example:
chebyshevu_root(3, 2)
Expected:
-1/2*2**(1/2)
Got:
-2**(1/2)/2
________________________________________________________________________________
________________________ sympy.geometry.ellipse.Circle
_________________________
File "/home/ondrej/repos/sympy/sympy/geometry/ellipse.py", line 288, in
sympy.geometry.ellipse.Circle
Failed example:
c2.hradius, c2.vradius, c2.radius, c2.center
Expected:
(1/2*2**(1/2), 1/2*2**(1/2), 1/2*2**(1/2), Point(1/2, 1/2))
Got:
(2**(1/2)/2, 2**(1/2)/2, 2**(1/2)/2, Point(1/2, 1/2))
________________________________________________________________________________
_______________________ sympy.geometry.util.intersection
_______________________
File "/home/ondrej/repos/sympy/sympy/geometry/util.py", line 22, in
sympy.geometry.util.intersection
Failed example:
intersection(c, l2)
Expected:
[Point(1 - 1/5*5**(1/2), 1 + 2*5**(1/2)/5), Point(1 + 1/5*5**(1/2), 1 -
2*5**(1/2)/5)]
Got:
[Point(1 - 5**(1/2)/5, 1 + 2*5**(1/2)/5), Point(1 + 5**(1/2)/5, 1 -
2*5**(1/2)/5)]
________________________________________________________________________________
__________________ sympy.integrals.trigonometry.trigintegrate
__________________
File "/home/ondrej/repos/sympy/sympy/integrals/trigonometry.py", line 34, in
sympy.integrals.trigonometry.trigintegrate
Failed example:
trigintegrate(sin(x)*cos(x), x)
Expected:
1/2*sin(x)**2
Got:
sin(x)**2/2
________________________________________________________________________________
____________________ sympy.polys.polynomial.Poly.integrate
_____________________
File "/home/ondrej/repos/sympy/sympy/polys/polynomial.py", line 1646, in
sympy.polys.polynomial.Poly.integrate
Failed example:
p.integrate(x, 2)
Expected:
Poly(1/12*x**4*y + 1/2*z**2*x**2, x, y)
Got:
Poly(1/12*x**4*y + z**2/2*x**2, x, y)
**********************************************************************
File "/home/ondrej/repos/sympy/sympy/polys/polynomial.py", line 1649, in
sympy.polys.polynomial.Poly.integrate
Failed example:
p.integrate(x, 2, y)
Expected:
Poly(1/24*x**4*y**2 + 1/2*z**2*x**2*y, x, y)
Got:
Poly(1/24*x**4*y**2 + z**2/2*x**2*y, x, y)
**********************************************************************
File "/home/ondrej/repos/sympy/sympy/polys/polynomial.py", line 1652, in
sympy.polys.polynomial.Poly.integrate
Failed example:
p.integrate(z)
Expected:
Poly(z*x**2*y + 1/3*z**3, x, y)
Got:
Poly(z*x**2*y + z**3/3, x, y)
________________________________________________________________________________
__________________________ sympy.series.limits.Limit
___________________________
File "/home/ondrej/repos/sympy/sympy/series/limits.py", line 110, in
sympy.series.limits.Limit
Failed example:
Limit(sin(x)/x, x, 0)
Expected:
Limit(1/x*sin(x), x, 0)
Got:
Limit(sin(x)/x, x, 0)
________________________________________________________________________________
______________________ sympy.simplify.simplify.nsimplify
_______________________
File "/home/ondrej/repos/sympy/sympy/simplify/simplify.py", line 1042, in
sympy.simplify.simplify.nsimplify
Failed example:
nsimplify((1/(exp(3*pi*I/5)+1)))
Expected:
1/2 - I*(1/4 + 1/10*5**(1/2))**(1/2)
Got:
1/2 - I*(1/4 + 5**(1/2)/10)**(1/2)
________________________________________________________________________________
_______________________ sympy.simplify.simplify.radsimp
________________________
File "/home/ondrej/repos/sympy/sympy/simplify/simplify.py", line 839, in
sympy.simplify.simplify.radsimp
Failed example:
radsimp(1/(2+sqrt(2)))
Expected:
1 - 1/2*2**(1/2)
Got:
1 - 2**(1/2)/2
________________________________________________________________________________
_________________________ sympy.solvers.solvers.tsolve
_________________________
File "/home/ondrej/repos/sympy/sympy/solvers/solvers.py", line 691, in
sympy.solvers.solvers.tsolve
Failed example:
tsolve(log(x) + 2*x, x)
Expected:
[1/2*LambertW(2)]
Got:
[LambertW(2)/2]
________________________________________________________________________________
____________________ sympy.statistics.distributions.Normal
_____________________
File "/home/ondrej/repos/sympy/sympy/statistics/distributions.py", line 69,
in
sympy.statistics.distributions.Normal
Failed example:
N.probability(-1, 3)
Expected:
erf(1/2*2**(1/2))
Got:
erf(2**(1/2)/2)
________________________________________________________________________________
______________________ sympy.statistics.distributions.PDF
______________________
File "/home/ondrej/repos/sympy/sympy/statistics/distributions.py", line
226, in
sympy.statistics.distributions.PDF
Failed example:
exponential.pdf(x)
Expected:
1/a*exp(-x/a)
Got:
exp(-x/a)/a
________________________________________________________________________________
_________________ sympy.statistics.distributions.PDF.normalize
_________________
File "/home/ondrej/repos/sympy/sympy/statistics/distributions.py", line
262, in
sympy.statistics.distributions.PDF.normalize
Failed example:
exponential.normalize().pdf(x)
Expected:
1/a*exp(-x/a)
Got:
exp(-x/a)/a
============ tests finished: 195 passed, 16 failed in 1.91 seconds
=============
DO *NOT* COMMIT!
Attachments:
0001-Fixed-printing-tests.patch 3.7 KB
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sympy-issues" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sympy-issues?hl=en
-~----------~----~----~----~------~----~------~--~---
