Updates:
        Cc: smichr

Comment #8 on issue 1644 by asmeurer: Coeff() with derivatives and functions
http://code.google.com/p/sympy/issues/detail?id=1644

I saw this in the patch:

      def as_numer_denom(self):
          # a/b -> a,b
-        from sympy.core.relational import Equality
-        from sympy import Eq
-        if isinstance(self, Equality):
-            l = Symbol('l', dummy=True)
-            r = Symbol('r', dummy=True)
-            n, d = (l*self.lhs - r*self.rhs).as_numer_denom()
-            return Eq(n.subs({l: 1, r: 0}),
-                      n.subs({l: 0, r: -1})), d.subs({l: 1, r: 1})
+        if 0: #this is not a trivial change...it causes many failures
+            from sympy.core.relational import Equality
+            from sympy import Eq
+            if isinstance(self, Equality):
+                l = Symbol('l', dummy=True)
+                r = Symbol('r', dummy=True)
+                n, d = (l*self.lhs - r*self.rhs).as_numer_denom()
+                return Eq(n.subs({l: 1, r: 0}),
+                          n.subs({l: 0, r: -1})), d.subs({l: 1, r: 1})
          base, exp = self.as_base_exp()
          coeff, terms = exp.as_coeff_terms()

What is the purpose of putting this code block in an if block that will  
never get run?  Does it break anything?

By the way, I will review the ode part later today.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sympy-issues" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/sympy-issues?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to