Comment #2 on issue 1628 by [email protected]: residue() function implemented http://code.google.com/p/sympy/issues/detail?id=1628
I've reviewed the patches and while the code in the first one does what it says on the tin and is properly tested, I believe that the second one doesn't fully solve the problem of the name clash between sympy.series.residues.residue() and sympy.ntheory.residue. In sympy/ntheory/__init__.py, residue is deleted but never imported and this causes bin/doctest to fail for this file. However, it might be argued that there's little point in doctesting an __init__.py. There is also the matter of the first patch failing the tests it implements, due to the name clash: I thought there was a policy that no commit should do that. If that's the case, it should be squashed with a proper solution to the clash. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "sympy-issues" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/sympy-issues?hl=en -~----------~----~----~----~------~----~------~--~---
