Comment #10 on issue 1757 by asmeurer: fem.py with incorrect identation
http://code.google.com/p/sympy/issues/detail?id=1757
Wow, that is a lot of changes. Don't worry, it is standard practice to run
the tests before committing.
All tests pass for me. What is this hilbert thing you are referencing?
I noticed some changes like this:
@@ -936,29 +936,29 @@ def checkodesol(ode, func, sol, order='auto',
solve_for_func=True):
order = ode_order(ode, func)
if solve_for_func and not (sol.lhs == func and not sol.rhs.has(func))
and not \
(sol.rhs == func and not sol.lhs.has(func)):
- try:
- solved = solve(sol, func)
- if solved == []:
- raise NotImplementedError
- except NotImplementedError:
- pass
+ try:
+ solved = solve(sol, func)
+ if solved == []:
+ raise NotImplementedError
+ except NotImplementedError:
+ pass
+ else:
I guess the change is fine, but I think that if you implement your script
in strip_whitespace (which it would still be great if you
did), then maybe you should leave that out. Personally, I think it is
easier to read the code when lines below nested if
statements are indented one level deeper than the deepest part of the if
statement, but the point is that I don't think we
should force either way in this case in strip_whitespace.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"sympy-issues" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sympy-issues?hl=en.
