Updates:
        Labels: -NeedsReview NeedsBetterPatch

Comment #31 on issue 1778 by Vinzent.Steinberg: Rational from string can be improved
http://code.google.com/p/sympy/issues/detail?id=1778

Thanks, looks good, all the tests pass...

-        if isinstance(obj,tuple) and len(obj)==2:
+        if isinstance(obj, tuple) and len(obj)==2:

While you're at it, you could also fix the spacing around '=='. :)

rsimplify() needs a docstring with a doctest. And a trivial wrapper should be added
to Expr(). See the patch doing this for simplify() currently under review.

I do not like the 'q' flag. It is just True or False? In this case it should be
renamed, because it looks like being an integer. Perhaps 'convert_real'.

I'm +1 for the rest.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"sympy-issues" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sympy-issues?hl=en.

Reply via email to