Status: Accepted
Owner: asmeurer
CC: Vinzent.Steinberg,  basti.kr
Labels: Type-Defect Priority-High NeedsReview

New issue 1970 by asmeurer: Failing tests in Python 2.4 in master
http://code.google.com/p/sympy/issues/detail?id=1970

________________________________________________________________________________
___________ sympy/core/tests/test_arit.py:test_suppressed_evaluation ___________ File "/users/aaronmeurer/documents/python/sympy/sympy/sympy/core/tests/test_arit.py", line 1038, in test_suppressed_evaluation
    a = Add(1,3,2,evaluate=False)
File "/Users/aaronmeurer/Documents/python/sympy/sympy/sympy/core/cache.py", line 85, in wrapper
    func_cache_it_cache[k] = r = func(*args, **kw_args)
File "/Users/aaronmeurer/Documents/python/sympy/sympy/sympy/core/operations.py", line 28, in __new__
    obj.is_commutative = all(arg.is_commutative for arg in args)
NameError: global name 'all' is not defined

And about 11 similar ones.  I bisected the problem to

e89bfc77633892ef069d2b8b3aee8e6fd5981135 is the first bad commit
commit e89bfc77633892ef069d2b8b3aee8e6fd5981135
Author: Sebastian Krämer <[email protected]>
Date:   Fri Apr 30 01:10:35 2010 +0200

    Fix issue 1864 (is_commutative is not always set)

    In the creation process of AssocOp and Pow the is_commutative attribute
    was not set if the keyword evaluate=False was given.
    Also tests are added.

    Signed-off-by: Vinzent Steinberg <[email protected]>

:040000 040000 488c918617ea0a28f59432853781003f518b7a0c 67c2f86a372601323507cde7a9bb96d52c64423c M sympy

And the solution is obvious (and easy). See attached patch or my 1970 branch.

Attachments:
        0001-Import-all-from-sympy.utilities.iterables-in-sympy-c.patch  720 
bytes

--
You received this message because you are subscribed to the Google Groups 
"sympy-issues" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sympy-issues?hl=en.

Reply via email to