Comment #8 on issue 2014 by asmeurer: sympy.solvers.solvers.solve should
also allow frozenset to hold equations
http://code.google.com/p/sympy/issues/detail?id=2014
I see, you just put it as a doctest. I would prefer to see them as regular
tests (sympy/solvers/tests/test_solve.py), since you are not showing
anything particularly interesting with the 4 doctests solving the same
thing. Just mention that any iterable can be used in the docstring
somewhere and move the tests to the normal test file.
As to the other changes, as I said, don't worry about it. Someone will
have a pleasant surprise if they try some strange iterable with some
function and find out that it works, but it isn't too important to test it
imho (or do others disagree?).
You make another good point:
for i in 1:
... print i
...
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: 'int' object is not iterable
is more informative than just TypeError("Not an iterable container")
because it tells you the type of the offending object. I think it's silly
to raise TypeError when the very next line would do it for you, so I am +1
on changing that everywhere. I thought this was in PEP 8, but I guess it
isn't. It probably belongs there, though.
--
You received this message because you are subscribed to the Google Groups
"sympy-issues" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sympy-issues?hl=en.