Comment #16 on issue 1985 by asmeurer: as_real_imag() gives wrong answer when expanding quotient
http://code.google.com/p/sympy/issues/detail?id=1985

Re 14: Well, it actually is, only maybe in a more contorted way. I wrote the commit message a while ago. The test itself isn't named in the commit message, but it references this issue, and is easily inferred as the addition to the test_* file.

Re 15: No, issue 1725 is completely unrelated to this issue. This issue is about as_real_imag() mostly. I did have to add a expand_multinomial() function because I needed that behavior, but that was only because issue 1725 hasn't been fixed yet (and I didn't want to block on it). Or did 1725 offer a similar fix? Really, there were a few ways to patch this issue (like see comment 7 above), but I'm still convinced that my fix was the only *correct* way to fix the issue.

I really wish more people could have looked at this (especially the changes to add.py), since it is a change to the core, but it was sitting in review status for quite some time, and Ondrej gave it the thumbs up. But, like I said, feel free to reopen and further critique if you find issues with what has been pushed in (code wise, obviously I can't change the commit messages now).

--
You received this message because you are subscribed to the Google Groups 
"sympy-issues" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sympy-issues?hl=en.

Reply via email to