Comment #7 on issue 1095 by [email protected]: Trig functions break cancel http://code.google.com/p/sympy/issues/detail?id=1095
But once again, I don't think Mateusz added a test for this.
It's a good question whether a test is necessary in this case. To meet our rule that every fixed issue must have a test (or tests) committed before closing the issue, then yes. On the other hand, the new design of polys allows to handle sin(x)**2 + 1 and x**2 + 1 exactly the same way and this is transparent from the point of view of cancel() and other polynomial (or rational function) manipulation functions. I don't have to mention that tests for handling polynomial-like expressions were committed already (possibly in polys12). My point is that we shouldn't add redundant tests for the sake of adding tests and if there is a new design, we should tests for the design, not for particular special cases.
Having a test for simplify(), to check if it properly calls cancel() (which is guaranteed by design to handle polynomial-like expressions), is a different story and in this case I think a test should be added, especially because currently there is no tests for this class of expressions (I mean rational functions with elementary function components that can trigger non-trivial invocation of cancel()).
-- You received this message because you are subscribed to the Google Groups "sympy-issues" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sympy-issues?hl=en.
