Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 3783 by [email protected]: Prufer.edges test depends on order of set
http://code.google.com/p/sympy/issues/detail?id=3783

the method Prufer.edges iterates through a set (sympy/combinatorics/prufer.py line 271), appending elements to a list (line 277). The test for this method (test_prufer.py lines 21-22) then check the resulting list against a hard-coded result directly. The order of set iteration is not deterministic, even for small sets, and is failing in PyPy 1.8 (32-bit).

The test should sort the resulting list and comapre it to a sorted hard-coded list rather than just relying on the order of set iteration.

Also, it iterates through the set in an "unpythonic" fashion.

while e:
  ei = e.pop()
  ....

could be replaced by
for ei in e:
  ....

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"sympy-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sympy-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to