Comment #5 on issue 3855 by [email protected]: Possible bug in
geometry.polygon
http://code.google.com/p/sympy/issues/detail?id=3855
The problem seems more complicated than I first thought.
The thing is that as it is right now, the test in line 170 (not
self.is_convex) is never truthy, so the lines below it have never been
executed.
If I change "is_convex" to "is_convex()", a few more bugs show up. Mostly,
I guess, because the code is two years old and after being untested for so
long, changes in the API introduced them without no one noticing.
But then, even if I update the code, I find another problem: the algorithm
for finding intersecting sides is wrong, as it gives a false positive in
one of the tests.
I've been thinking how to fix it, but I would say that the best option now
would be rewriting this part as an "is_simple" property. Also, in my
opinion, the lines about explicit intersections can be removed, as they add
an unnecessary complication. And considering that self intersections were
not being detected in the first place, they were never really needed.
PS. I'm sorry, but I couldn't find any guide in the link you provided.
Could you be more specific?
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"sympy-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sympy-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
