Status: Valid
Owner: ----
Labels: Type-Defect Priority-Medium EasyToFix Testing
New issue 3945 by [email protected]: XFAIL should include the expected
error
http://code.google.com/p/sympy/issues/detail?id=3945
XFAIL should indicate what kind of exception should be expected to fail. To
quote Chris from the mailing list:
"Currently, XFAIL works like an unconditional except-clause which we all
agree is a bad idea. And it's a bad idea for the XFAIL, too, because if you
don't define a variable properly the test will fail but not for the reasons
expected. Does anyone know how to modify XFAIL so it either 1) accepts the
type of error that it should fail for or 2) only fails for an assertion
error? And in either case prints E rather than F in the report so we know
that something is wrong with the test?"
I have modified XFAIL to work like @XFAIL([ValueError]) at
https://github.com/asmeurer/sympy/tree/xfail, but I didn't fix anything
else yet. What needs to be done:
- Change all tests
- Fix the py.test version
- It should automatically include the skip exception
- It should not kill the test runner if it is used incorrectly.
- Document it, or update existing documentation
- It maybe should automatically include AssertionError.
If anyone decides to do this, it would also be a good opportunity to go
through and fix issue 3472.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"sympy-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sympy-issues.
For more options, visit https://groups.google.com/groups/opt_out.
