Hi Matthew, On Fri, Jul 23, 2010 at 8:48 PM, Ondrej Certik <[email protected]> wrote: > On Fri, Jul 23, 2010 at 8:37 PM, Matthew Brett <[email protected]> > wrote: >> Hi, >> >>>> I also don't feel strongly either way. I would use "_imp_" though, >>>> that seems to be the best. >>> >>> It shall be so ;) >> >> Done; I also responded to Ondrej's github review, thanks for that, > > Awesome. I am now going to Reno, so I'll look at this tomorrow.
I have reviewed your changes, all is ok. Except that by adding doctests, you introduced couple more trailing whitespaces, so the test failed, but I just fixed that myself and pushed it in. Thanks for the contribution! Ondrej -- You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sympy-patches?hl=en.
