On Thu, Mar 26, 2009 at 7:30 PM, Gael Varoquaux <[email protected]> wrote: > > On Fri, Mar 27, 2009 at 03:23:04AM +0100, Gael Varoquaux wrote: >> > Let's make a deal --- I'll fix this for you and you'll review my >> > patches that are holding off the sympy release: > >> > http://code.google.com/p/sympy/issues/list?q=label:NeedsReview > >> > :) > >> > Then we can release sympy *and* have it fixed. > >> Sounds like a deal. > > I am being stupid: do you have a clear workflow for reviewing? The docs > are all about hg. I am not sure how to proceed. Do I need to pull from a > branch (the tickets are not clear what the url of the branch is) and > review locally, or is there a web-app to do this?
In this case just go to the issue, find the patch and look at it and think if it's ok to be in sympy, or if it needs more work. And say your opinion in the issue. All tests pass, but I want someone else to look at it before I push it in. Cool, you didn't tell me you will be here! Will you be in Berkeley over the weekend? If so, maybe I can come if I manage to find someone with a car. Ondrej --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/sympy?hl=en -~----------~----~----~----~------~----~------~--~---
