I commented on your github account (go to http://github.com/ryanGT/sympy/comments to see). I am +1 assuming that .as_numer_denom() will always return the same result for p/q and (-p)/q (it probably should) and also given my comment.
Aaron Meurer On Jun 27, 2009, at 1:14 PM, Ryan Krauss wrote: > I think I have fixed this issue. I put a solution on branch > minus_sign_1495 > on my github repo > git://github.com/ryanGT/sympy.git > > Comments welcome, > > Ryan > > On Sat, Jun 27, 2009 at 1:18 PM, Ondrej Certik <[email protected]> > wrote: > > On Sat, Jun 27, 2009 at 12:04 PM, Aaron S. > Meurer<[email protected]> wrote: > > > > I get False on Mac OS X 10.5 with Python 2.6.2. > > > > Changing could_extract_minus_sign to make it smarter would be fine, > > but I think it does not fix the main issue here. Namely, the same > > thing in sympy should hash to the same value on any computer. > > That's impossible to do, unless we write our own hash, which will be > too slow. We may write a hash in Cython, but then it will not work in: > > > pure python. > > However, hash is an internal thing, users should not see it nor touch > it. So all we have to do is just to fix things in sympy, so that they > are hash independent. > > Ondrej > > > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/sympy?hl=en -~----------~----~----~----~------~----~------~--~---
