There are these two tests in test_algebratools.py:

assert QQ[x].get_ring() == ZZ[x]

assert QQ[x].get_field() == ZZ.frac_field(x)

But something is wrong.  Either 

(1) the tests should be 

assert QQ[x].get_ring() == QQ[x]

assert QQ[x].get_field() == QQ.frac_field(x)

or 

(2) it isn't implemented properly:

In [1]: QQ[x].get_ring()
Out[1]: QQ[x]

In [2]: QQ[x].get_field()
Out[2]: QQ(x)

If I had to guess, I would say that it should be (1), because the outer-most 
ring is the polynomial ring.  

By the way, I came across this by fixing a bug where Poly(-t + x, t, 
domain='ZZ[x]')*Poly(1, t, domain='QQ') fails with gmpy ground types, because 
it does not properly unify to QQ[x], which in turn is caused by:

In [3]: ZZ[x] == QQ[x]
Out[3]: True

Of course, this was a trivial fix, but then these tests popped up as failing, 
and I was not sure what to do with them.

Aaron Meurer

P.S. to Mateusz: it would really help if you popped into IRC every once in a 
while, so I don't have to send trivial questions like this that only you would 
know the correct answer to to the mailing list.  Remember that you are my 
mentor. :)

-- 
You received this message because you are subscribed to the Google Groups 
"sympy" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sympy?hl=en.

Reply via email to