Great! One thing that I can see right away in GitX is that you need to clear trailing whitespace in your files. The bin/strip_whitespace utility will help you with this, and the sympy/utilities/tests/test_code_quality.py test will tell you if you have any. It's a good idea to run ./bin/test before committing anyway.
Looking forward to your work. Aaron Meurer On Jun 10, 2010, at 10:59 AM, Harold E. wrote: > Thanks to Vinzent I created a repo on Github with a branch for units : > http://github.com/melsophos/sympy/tree/units > I will work on it essentially during the summer since I'm in stage > now. > > Harold > > On 16 mai, 19:43, Vinzent Steinberg <[email protected]> > wrote: >> On 16 Mai, 00:11, "Harold E." <[email protected]> wrote: >> >>> On 15 mai, 23:40, "Aaron S. Meurer" <[email protected]> wrote: >> >>>> Go ahead and create an issue for it. If you can push the changes up to >>>> github, that would also make things easier. >> >>> There is no need to have a certain status to push? Also is it not >>> preferable to wait that my code is almost done? >> >> It does not hurt to publish your work in progress on github, so we can >> already have a look at it before. Of course it will be pushed to >> master only if done. >> >> Release early, release often. :) >> >> Vinzent >> >> -- >> You received this message because you are subscribed to the Google Groups >> "sympy" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]. >> For more options, visit this group >> athttp://groups.google.com/group/sympy?hl=en. > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/sympy?hl=en. > -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
