This makes me realize that we should have some way to indicate who has the branch for review in a NeedsReview issue (I have no idea which of those issues have a branch from me, without looking at each individually). Any ideas? Maybe we could add the person's user name as a label.
Aaron Meurer On Aug 31, 2010, at 6:21 PM, Ondrej Certik wrote: > Hi, > > github just introduced a nice review system: > > http://github.com/blog/712-pull-requests-2-0 > > so I have just uploaded my first pull request: > > http://github.com/sympy/sympy/pull/1 > > you can see all sympy pull requests here: > > http://github.com/sympy/sympy/pulls > > > Let's see how it works. Here are our current "pull requests": > > http://code.google.com/p/sympy/issues/list?q=label:NeedsReview > > if you are an author of some of those patches, do you think you can > please upload your patch to github and create a pull request against > the sympy/sympy github repository? All people who have push access > should be notified, and it should appear in the pull request page. > That way we can test if it simplifies our workflow. > > Ondrej -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
