On Mar 1, 3:00 pm, "Chris Smith" <[email protected]> wrote:
> Julien Rioux wrote:
> >          if reeval:
> > -            return Mul.flatten(c_part)
> > +            return Mul.flatten(c_part+nc_part)
> >          return c_part, nc_part, order_symbols
>
> The reeval is only needed to update the c_part. So instead of returning right 
> away it would be better to update the c_part and then return everything, 
> including the order_symbols which the above code would drop. (see issue 2201 
> and ref to pull request)
>
> /c

Your patch looks good.

-- 
You received this message because you are subscribed to the Google Groups 
"sympy" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sympy?hl=en.

Reply via email to