On Mar 11, 2011, at 5:38 PM, Kate MacInnis wrote: >> >> Yes, Chris's hint manager was to make this easier so you could just call >> distribute_constant=True, and it would automatically make all the others >> false. But it was never finished. > > Nice to know. I was thinking that something like that would make sense. > > >> >>> >>> I've got most tests working, although there are still several to fix. >>> >>> There is some unexpected, but not necessarily broken behavior. >>> Denominators seem to be automatically rationalizing themselves in some >>> places that they didn't before. Is that acceptable behavior? >> >> Can you give an example of what you mean here? > > In test_spec_polynomials, > roots(legendre(4,x), x) > is expected to return (among other roots) > ⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽ > ╱ ⎽⎽⎽⎽ > ╱ 2⋅╲╱ 30 > ╱ 3/7 - ──────── > ╲╱ 35 > > and it now gives > > ⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽ > ⎽⎽⎽⎽ ╱ ⎽⎽⎽⎽ > ╲╱ 35 ⋅╲╱ 15 - 2⋅╲╱ 30 > ───────────────────────── > 35 > > > All four roots come out in this format (the line length made pasting > the whole dict look awful)
So if you enter the top one, is it automatically converted to the bottom one, or is it just an issue of roots() returning a differently formatted result? If it's the first one, then there might be a problem to consider, but if it's the second one, then I wouldn't worry about it. Just update the tests in that case. As long as they are mathematically equivalent, it's fine. Now if it's doing this for square roots with variables, then it might be a problem, because sqrt(x*y) != sqrt(x)*sqrt(y) in general for complex x and y. Aaron Meurer -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
