Sounds good. Let us know if you need help making the patch using git. Aaron Meurer
On Mar 19, 2011, at 4:03 AM, SherjilOzair wrote: > Thank you, > I've been reading the Matrices class. > > The SMatrix class borrows its transpose, determinant and mult > functions from Matrix, and thus is inefficient for Sparse Matrices. > > > The transpose doesn't even work for SMatrix. > > >>>> a=SMatrix(10,10,lambda i,j:isprime(i)) >>>> a.T > Traceback (most recent call last): > File "<console>", line 1, in <module> > File "sympy/matrices/matrices.py", line 187, in transpose > a[i*self.rows:(i+1)*self.rows] = self.mat[i::self.cols] > TypeError: unhashable type >>>> > > I intend to correct this bug. I have coded in another representation, > which is basically a list of all non-zero elements. > I'll edit the transpose method in SMatrix to make use of this > representation for efficiency. > > I will correct the bug too and make room for increase in efficiency in > SMatrix methods by using the alternate representation. > > This will be my easy patch, and my first contribution to Sympy. > Any suggestions ? > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/sympy?hl=en. > -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
