I resolved the QR decomposition + rational matrix powers + LU doctests pull request fyi. Pull request for issue 841 is also clean imo.
The elliptic integral patch was done because of a grep for #TODO that i did on the codebase. There are many such TODOs and FIXMEs and they dont really have an entry in the issues page. On Apr 18, 4:03 am, "Aaron S. Meurer" <[email protected]> wrote: > Don't forget to close the corresponding issue when you push a branch in (I > have already closed the two for the ones you did). By the way, did the > elliptic integral patch have an issue corresponding to it? There was none > mentioned in the commit message. > > Aaron Meurer > > On Apr 16, 2011, at 9:27 PM, Ondrej Certik wrote: > > > > > > > > > Hi Saptarshi, > > > There were some trivial test failures and merge conflicts, so I fixed > > things that I could and pushed in 3 pull requests. Thanks for the > > contributions! > > > The 4th one has a nontrivial merge conflict. Could you please resolve it? > > > Ondrej > > > On Sat, Apr 16, 2011 at 5:28 AM, Saptarshi Mandal > > <[email protected]> wrote: > >>https://github.com/sympy/sympy/pull/228 > >>https://github.com/sympy/sympy/pull/226 > >>https://github.com/sympy/sympy/pull/205 > >>https://github.com/sympy/sympy/pull/188 > > >> Please feel free to review it ofcourse, but afaik, there should not be > >> any whitespace errors, and all tests pass. > > >> On Apr 16, 3:52 pm, Ondrej Certik <[email protected]> wrote: > >>> On Sat, Apr 16, 2011 at 3:47 AM, Saptarshi Mandal > > >>> <[email protected]> wrote: > >>>> Hi, > >>>> I updated my application to include some notes i wrote while > >>>> researching permutation groups. You can find it here > >>>>https://github.com/sympy/sympy/wiki/Some-notes-regarding-Permutation-... > >>>> I have written down the algorithms in a nice psuedocode format. If > >>>> anyone has any questions please let me know. > > >>>> Also I have a backlog of 9 pull requests of which I think atleast 5 > >>>> are good to go in. My workflow is extremely cluttered now because of > >>>> multiple unmerged branches and would appreciate if someone could merge > >>>> my changes so that I can (move on with my life) get rid of issue > >>>> specific branches on my local machine. > > >>> Can you post links to pull requests that are ready to go in? I can push > >>> it in. > > >>> Ondrej > > >> -- > >> You received this message because you are subscribed to the Google Groups > >> "sympy" group. > >> To post to this group, send email to [email protected]. > >> To unsubscribe from this group, send email to > >> [email protected]. > >> For more options, visit this group > >> athttp://groups.google.com/group/sympy?hl=en. > > > -- > > You received this message because you are subscribed to the Google Groups > > "sympy" group. > > To post to this group, send email to [email protected]. > > To unsubscribe from this group, send email to > > [email protected]. > > For more options, visit this group > > athttp://groups.google.com/group/sympy?hl=en. -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
