Those are good questions. I agree with Aaron and Andy. The best way is to post an email into the list, with a link to your branch, to receive feedback, with some simple instructions what to execute to try it out.
Ondrej On Wed, Jun 8, 2011 at 7:21 AM, Andy Ray Terrel <[email protected]> wrote: > Feel free to ask me to look at a branch. That's what I'm here for. > > Additionally what is "quality" code is usually subject to the dev. If > it is PEP 8 compliant and doesn't have any major design flaws its > usually okay. > > -- Andy > > On Fri, Jun 3, 2011 at 7:45 PM, Aaron S. Meurer <[email protected]> wrote: >> You should submit a pull request only if you feel that your code is ready to >> be merged in. So 2. >> >> If you just want feedback, you can write to the list with a link to your >> branch on GitHub. It's even possible for people to leave comments on lines >> of code without you creating a pull request. You can also create an issue >> in the issue tracker and put a link to your branch there. >> >> Aaron Meurer >> >> On Jun 3, 2011, at 1:50 PM, Matthew Rocklin wrote: >> >>> Hi Folks, >>> >>> Regarding pull requests there are (for me) two competing interests: >>> >>> 1) I want feedback on my unfinished code >>> 2) I want to present a polished product to the SymPy community >>> >>> At what stage in my code's development is it proper to submit a pull >>> request? >>> >>> -Matt >>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "sympy" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]. >> For more options, visit this group at >> http://groups.google.com/group/sympy?hl=en. >> >> > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/sympy?hl=en. > > -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
