Hi Sean and Stefan,

On Thu, Jun 16, 2011 at 3:03 PM, Sean Vig <[email protected]> wrote:
> I have a pull request open for this here
> https://github.com/sympy/sympy/pull/431
> Feel free to review and comment, thanks.
>
>> Did you noticed that in master qapply(Jx*JxKet(...)) does not evaluate to
>> ...*hbar*JxKet. Jz*JzKet evaluates as expected but not the other two base
>> kets. Maybe it has nothing to do with your problem, but as you are rewriting
>> operators and states it may intervene.
>
> I see, I'll see if I can't look at that
>
>>
>> Concerning the printing you can see what I propose here
>> https://github.com/sympy/sympy/pull/186 This pull request is a mess. I
>> should squash many of the commits, but the diffs are clear.
>
> I'll definitely help review that, I'll check it out.

Thanks both of you. Yes, if you can help review each other's pull
requests, that would be absolutely awesome. I am running the sympy-bot
tests on them now.

Off to the library to checkout the Varshalovich book.

Ondrej

-- 
You received this message because you are subscribed to the Google Groups 
"sympy" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sympy?hl=en.

Reply via email to