It will merge cleanly. I am running the sympy-bot tests now. Aaron Meurer
On Mon, Jul 25, 2011 at 6:13 PM, Haz <[email protected]> wrote: > I've reviewed it a number of times. If there are still problems, it's > likely something that I won't pick up (like reading your own reading -- you > just see it correctly rather than seeing any mistakes that may be there :p). > It's also been looked at by others in the community (see those participating > in the pull request), but likely not as much as I've picked through it. > So long answer short -- if it merges / tests fine, then I think it's good > to be pulled in. > Cheers > > On Mon, Jul 25, 2011 at 8:05 PM, Aaron Meurer <[email protected]> wrote: >> >> So has it passed review and you just need someone to push it in, or do >> you need help reviewing it still? >> >> Aaron Meurer >> >> On Mon, Jul 25, 2011 at 6:02 PM, Haz <[email protected]> wrote: >> > Excuse the stutter ;). There is a pull request [0] that has gone >> > through a >> > number of iterations and contains quite a large chunk of code that is >> > needed >> > for further work in Saptarshi's SoC plans. Could high dev higher up >> > please >> > take a final gander / pull it into the trunk so progress can continue? >> > Thanks. >> > Cheers, >> > Christian >> > [0]: https://github.com/sympy/sympy/pull/330 >> > >> > -- >> > You received this message because you are subscribed to the Google >> > Groups >> > "sympy" group. >> > To post to this group, send email to [email protected]. >> > To unsubscribe from this group, send email to >> > [email protected]. >> > For more options, visit this group at >> > http://groups.google.com/group/sympy?hl=en. >> > >> >> -- >> You received this message because you are subscribed to the Google Groups >> "sympy" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]. >> For more options, visit this group at >> http://groups.google.com/group/sympy?hl=en. >> > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/sympy?hl=en. > -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
