On Aug 5, 5:49 am, Aaron Meurer <[email protected]> wrote: > Just review the diff (esp. the most recent commit, i.e., the merge > commit). I'll push the merge button.
I'm not trying to be obtuse, but the diff is about 8000 lines long and I don't know what I would be looking for. I wouldn't really be reviewing it in the sense that I review a pull request since this has already been done. And if a mistake has been made in the merging process by you, that's not going to be transparent. And the "last commit"? That's 1f881c2f447ff735faabaf0a2132e7d4be7dca18, right? That's perhaps the same thing as the whole diff since it is about 8000 lines, too. So I really need more direction of exactly which commit to look at and to know what I'm looking for. Saptarshi's Subsets branch is only 1000 lines long and that's taken me about 6 hours so far to look at. I can't imagine looking at 8000 lines for the next 48 hours. And I don't think you want me to look this hard. But I don't know what glasses you *do* want me or someone else to wear. /c -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
