On Mon, Aug 8, 2011 at 9:35 PM, Aaron Meurer <[email protected]> wrote: > If you want something easy, all three of my open requests are very easy. > > It would indeed be great if the GSoC students could help each other > out in reviews. You should know by now what sort of things to look > for. Make sure that the code looks well structured and clean (PEP 8, > etc.). Check out the branch and make sure it does what it advertises. > Run the sympy-bot. If there is a branch that modifies something you > feel more comfortable with, review that. > > If you want to know what's higher priority, I would say that older > pull requests (if you click on "Submitted" in the pull requests view > so that the arrow points up, it will show the oldest requests at the > top), pull requests from issues that have high priority (at the top of > the list at > http://code.google.com/p/sympy/issues/list?can=2&q=label%3ANeedsReview+&colspec=ID+Type+Status+Priority+Milestone+Owner+Summary+Stars&cells=tiles), > and large pull requests (sorry, I don't know any easy way to get > these) are higher priority. And any pull request of GSoC work should > have higher priority. > > If you want to help but don't feel comfortable reviewing, but do feel > comfortable doing some web coding, here's an idea: GitHub has a very > extensive API (http://developer.github.com/). Code up a tool that > makes it easier to sort out pull requests based on things like what > code was touched and how big the request is. > > Or you could improve sympy-bot (see > https://github.com/sympy/sympy-bot/issues for some ideas). > > And if you want to help but are feeling really lazy, just run the > sympy-bot on pull requests that don't already have reviews after the > most recent commit. If you read the README for sympy-bot, it will > tell you how to add your GitHub info to a config file. Then you can > run it unmanned. If you use my branch from > https://github.com/sympy/sympy-bot/pull/26, the following command will > test *all* open pull requests (warning, currently there are 49 of > them) > > ./sympy-bot list-numbers | xargs ./sympy-bot review > > Aaron Meurer
So I made a little (hackish) addition to sympy-bot that prints a summary of the results in the comment (see https://github.com/sympy/sympy-bot/pull/29), and am in the process of doing this myself. Sorry for any duplicate reviews, and for spamming people with sympy-bot test results in general :) And I should note that the command should be xargs -L 1 ./sympy-bot review. Aaron Meurer > > On Mon, Aug 8, 2011 at 4:36 PM, Chris Smith <[email protected]> wrote: >> On Tue, Aug 9, 2011 at 4:15 AM, Matthew Rocklin <[email protected]> wrote: >>> Hi Everyone, >>> My understanding is that we're about to enter a huge pull request phase. As >>> a GSoC student I'm happy to help but am daunted about giving feedback to >>> parts of the code to which I am unfamiliar. As I look through the list of >>> active pulls nothing catches my eye as being a reasonable thing for me to >>> give feedback on. Are there easy tasks that GSoC students can take on to >>> ease the burden on the core developers? >> >> I've got 7 pulls waiting, many fairly short, but one rather long >> (solver mods). The 8th one related to subs is in limbo. >> >> /c >> >> -- >> You received this message because you are subscribed to the Google Groups >> "sympy" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]. >> For more options, visit this group at >> http://groups.google.com/group/sympy?hl=en. >> >> > -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
