Am 03.11.2011 02:58, schrieb Ondřej Čertík:
On Wed, Nov 2, 2011 at 4:44 PM, Aaron Meurer<[email protected]>  wrote:
See also here:

http://help.github.com/send-pull-requests/

Thanks.
I see where it's going wrong now: my branch isn't listed.
Which turned out to be the case because I forgot to specify the branch on git push.

Plus, I had overlooked the "master" in "never type the following commands in master: git merge, git commit, git rebase". I think it wasn't clear to me that "master" was referring to a branch name (the word is awfully overloaded).

I suggest rewording that to "you should type the following commands only in your own work branches (like 1234_sequence in the example above), never in the master branch"
It might help to italicize branch names in general.

Phew. I got the pull request in :-)
Note that I don't know yet whether it actually fixes the issue, since I haven't tested the code with Symbols yet. It's just a change that's useful enough to go in right now.

Regards,
Jo

--
You received this message because you are subscribed to the Google Groups 
"sympy" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sympy?hl=en.

Reply via email to