Le vendredi 30 mars 2012 à 02:35 +0300, Sergiu Ivanov a écrit : > Hello, > > This is the draft of my proposal about Groebner walk: > > > https://github.com/sympy/sympy/wiki/GSoC-2012-Application-Sergiu-Ivanov:-Generic-Gr%C3%B6bner-Walk > > I'd be very happy to hear some feedback :-) > > Sergiu > This looks like it'll be a solid proposal. In particular, you do a good job of summarising the feasibility of your project, its evaluation criteria and the benefits it would bring. However, some points (particularly the section "Infrastructure setup") could be made more concrete if you wrote some doctest-ish pseudocode. Bonus points if the code actually works.
I don't know much about the subject, so I only have a few specific comments: > As a way to better structure the code, I propose a (partial) transition to object-oriented design. Yay! +10. > I suggest defining a very basic class Operation which will initially contain one method with two arguments, which will perform the operation itself. I suspect that having to use the object in order to perform the operation would be cumbersome, so it might be more fruitful to consider Operation as a description of the operation, instead of as the operation itself. > I will start by defining the function nextPoint() "nextPoint" isn't PEP8-compliant. It should be "next_point". > July 9 - July 15: start merging the changes upstream; start working on the documentation; That's rather late. Any pull request with more than ~10 commits is painful to review. A pull request at that stage is likely to contain a few dozen commits, so you'd be lucky if it got merged before the end of August. You should endeavour to send pull requests as soon as you have a consistent and well-tested piece of functionality. -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
