On Wed, Jun 13, 2012 at 8:31 AM, Ronan Lamy <[email protected]> wrote: > Le mercredi 13 juin 2012 à 02:06 -0700, Aleksandar Makelov a écrit : >> Hi again, >>
... > >> - remove the checks from Perm, and make a *function* PermS (the name >> is deliberately chosen to be as close as Perm) that performs the >> checks and then constructs a permutation object using Perm (the name >> comes from Permutation Safe). > > Urgh, no! The design is OK, though not terribly consistent with the rest > of sympy where users need to directly call class constructors all the > time, but the naming seems designed to maximise user confusion. Casual > users shouldn't need to know about the concept of permutation > "safeness", nor have to remember a cryptic abbreviation for it, and > functions names (conventionally lowercase) shouldn't make them look like > classes. I'm a little confused. Is PermS a user function? I thought it was internal. If it is internal, and not a function for the casual user, then it might be renamed _PermS, so it doesn't pop up in tab completion. Also, a line or two on the abbreviation conventions in the top-level docstring might help the casual user. > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/sympy?hl=en. > -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
