On Mon, Jul 23, 2012 at 2:56 AM, Matthew Rocklin <[email protected]> wrote: > > I am +1 to sorting args on creation. > > This is a simple and exhaustive fix.
Agreed. > I think that FiniteSet is usually used for small sets and that sorting isn't > that expensive even for large ones. I think that this discussion is > premature optimization. If a use case arises that requires very large > FiniteSets then I think that we should revisit this issue. Until then I > think that we should revert the change and fix the issues in master. I agree with this as well, but I'd still be willing to get further feedback on the lazy approach. It doesn't seem to be more difficult to pull off than sorting .args in the constructor but, on the other hand, it addresses the performance issue Ronan is worried about (however premature the said optimisation may be). Unless someone talks me out of it, I'd really feel like backing the lazy approach; maybe I'm biased. Sergiu -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
