On Wednesday, August 8, 2012 3:23:49 PM UTC+5:30, Stefan Krastanov wrote: > > Thanks for the explanation. At some point I will move all this to the > issues list. > > >> - currently it overrides get_segments and get_points. Won't it be > >> cleaner if it overrides only get_points? Why not? (I think it will be > >> cleaner because the base LineSeries class already implements > >> get_segments based on get_points, and I would really hate to have the > >> logic reimplemented multiple time, as it is now) > > > > > > Yes. It would be better. But the problem is maintaining the order of > those > > points i.e > > if you want to insert new points between two points, then you will have > to > > create > > a new list. Adding to the same list is difficult. Also, the recursion > code > > will be more > > complex as it should be changed to something iterative rather than > > recursive. > > Python lists have a very quick insert() method. Is this sufficient? > Yeah. it might be sufficient, but I think it will still be more complex. I will give it a try sometime after I finish the plot api.
> > I have mentioned it on the PR page: the API is constrained by what is > implemented in the Series classes. It would be a bad idea to implement > it twice or to document it twice. All those options are already in > each of the Series classes. It would be unmaintainable to repeat it. > All these options will be added to the Series class itself. The only change is that these values are passed onto the Series class. I think documentation is necessary, thought it is repeated. For somebody, who is using the plot_*, it becomes necessary to have the options mentioned in the plot API. It will be difficult to figure it out from the Series docstrings. I am open to removing those options, if people feel it is bad practice / unnecessary. Thanks, Bharath M R -- You received this message because you are subscribed to the Google Groups "sympy" group. To view this discussion on the web visit https://groups.google.com/d/msg/sympy/-/sCXt-5J_tToJ. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
