> If there is good work, maybe someone can "adopt" the pull request by > rebasing and fixing test failures and code problems in a new pull > request. If the work really isn't that great, we should probably just > close it. We'll have to look on a case by case basis. What PRs are > like this?
PRs that somebody should adopt (some of these we might decide to close anyway): https://github.com/sympy/sympy/pull/1180 https://github.com/sympy/sympy/pull/786 https://github.com/sympy/sympy/pull/785 https://github.com/sympy/sympy/pull/677 https://github.com/sympy/sympy/pull/1220 https://github.com/sympy/sympy/pull/936 https://github.com/sympy/sympy/pull/1062 https://github.com/sympy/sympy/pull/797 https://github.com/sympy/sympy/pull/1258 https://github.com/sympy/sympy/pull/1125 https://github.com/sympy/sympy/pull/1326 https://github.com/sympy/sympy/pull/531 https://github.com/sympy/sympy/pull/447 https://github.com/sympy/sympy/pull/1222 https://github.com/sympy/sympy/pull/1009 https://github.com/sympy/sympy/pull/1158 https://github.com/sympy/sympy/pull/343 https://github.com/sympy/sympy/pull/525 https://github.com/sympy/sympy/pull/456 https://github.com/sympy/sympy/pull/444 https://github.com/sympy/sympy/pull/1293 https://github.com/sympy/sympy/pull/1408 https://github.com/sympy/sympy/pull/1413 PRs that I propose to simply close (the original author can always reopen them if new work is done): https://github.com/sympy/sympy/pull/1117 https://github.com/sympy/sympy/pull/1106 https://github.com/sympy/sympy/pull/1354 https://github.com/sympy/sympy/pull/957 https://github.com/sympy/sympy/pull/1154 https://github.com/sympy/sympy/pull/1207 https://github.com/sympy/sympy/pull/239 As you can see, at least half of our pull requests are abandoned. So I think that we should close the easy ones that either contain no useful work, or largely unfinished work. Then on the interesting pull requests, we need to decide on a case by case basis if we want this in sympy. If so, then some of us should make a serious attempt to fix it. If it cannot be done easily (without the original's author help), then I suggest to simply write why it is hard to fix it on our own and close it. Because then there is no need to have it open, if the original author is not going to work on it, and nobody else knows how to fix it. I propose to put "[UNFINISHED]" into the title of the pull request before closing it, so that people can easily look these pulls up in the closed pull requests view at github (in case somebody would like to reuse some stuff from that later). There will be a few pull requests that we really really want to get in, but nobody so far knows how to. Then we'll simply keep them open, so that people can see them and help out. Ondrej -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
