On Sat, Sep 1, 2012 at 11:50 PM, David Joyner <[email protected]> wrote: > On Sat, Sep 1, 2012 at 1:47 PM, Chris Smith <[email protected]> wrote: >> On Sat, Sep 1, 2012 at 11:26 PM, David Joyner <[email protected]> wrote: >>> On Sat, Sep 1, 2012 at 1:39 PM, Chris Smith <[email protected]> wrote: >>>> The big changes that breaks compatibility in a subtle way is that >>> >>> What does this mean? >> >> in master: >> >>>>> Permutation([1, 0, 2])*Permutation([0,2,1]) >> Permutation([1, 2, 0]) >> >> in this PR: >> >>>>> Permutation([1, 0, 2])*Permutation([0,2,1]) >> Permutation([2, 0, 1]) >> > > > Okay. But does it break lots of code in other modules?
Only in combinatorics, but I went through and changed all occurences to explicit lmul() calls. I know I have all instances covered because I put an assertion in `__mul__` (assert None) that caused an error to be raised so I could change foo*bar to lmul(foo, bar). (I think I looked at coverage to make sure that there were no muls in uncovered lines, too, but I should double check that.) -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
