On Sep 17, 2012, at 2:45 PM, "Ondřej Čertík" <[email protected]> wrote:
> On Fri, Sep 14, 2012 at 11:31 AM, Aaron Meurer <[email protected]> wrote: >> So I finally have submitted my Risch algorithm work from two years ago >> as a pull request. See https://github.com/sympy/sympy/pull/1530. >> There are still some issues that I need to iron out, but I would >> appreciate any feedback on the code, as well as tests on it. For now, >> you can test it with the risch_integrate() function. I will >> eventually replace this with integrate(risch=True). I'll poste a note >> on the pull request when this happens. >> >> If you do plan to review or try this, please see the pull request for >> some notes. > > If you can make all the tests reliably pass, and keep this as an > additional functionality, > then we should just merge it as soon as possible and then just improve > upon it in master. > So that we don't have to worry about conflicts any more and more > people can help by > simply sending PR against master as well as testing it from master. > > Ondrej I agree. There is at least one nontrivial thing that I still need to do to make tests pass, which is related to nondeterminism from iterating through a set. My hope is that I can fix this the "right" way, but it will require some thought. It's the same issue I discussed at http://asmeurersympy.wordpress.com/2011/06/05/nondeterminism/. I also at least want to change the API to use integrate, or else no one will use it. But everything else I will do in separate pull requests after this is merged. There is even a test failure that is caused by a regression in the matrices, which I will fix in a separate pull request (hopefully to be merged before this one). Since really all that remains is this, it would be great if people could look over the code that is there and see if it looks ok. Even if you don't understand a word of what's going on, you can at least comment on how things look. Aaron Meurer -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
